chore(atak): 104 — pick newest APK by modtime in install_device.sh - #108
Merged
Conversation
The previous `find ... | sort | tail` form selected APKs by lexicographic order, which silently mis-ranks versions where a higher-numbered build sorts before a lower one (e.g. v1.2.10 before v1.2.2). Switch to `ls -t` so the freshest build artifact is always installed, matching dev intent. Closes #104.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
atak/plugin/scripts/install_device.shwas selecting the APK to push viafind … *.apk | sort | tail -n 1, which is lexicographic order — a 1.2.10APK would lex-sort before 1.2.2 and silently install the older build.
Swap to
ls -1tso the most-recently-built artifact wins. Tiny helperfunction so we don't repeat the path twice.
ls -tis portable acrossmacOS (BSD) and Jetson (GNU).
Why this is trivial
Single 12-line shell diff in one file (
atak/plugin/scripts/install_device.sh),no behaviour change for the happy path of a single fresh APK, no new deps.
bash -nparses cleanly;make shellcheck-syntax,make lint, andmake test(332 tests) all pass.
Closes #104.